RFR 8214971 : Replace use of string.equals("") with isEmpty()
Lance Andersen
lance.andersen at oracle.com
Thu Dec 6 20:38:54 UTC 2018
HI Roger,
Changes seem good
> On Dec 6, 2018, at 3:04 PM, Roger Riggs <Roger.Riggs at oracle.com> wrote:
>
> Please review changing string.equals("") to string.isEmpty().
> isEmpty is preferred, performs better and is easier to optimize.
>
> The change is a literal substitution in all files and only in these modules:
>
> java.base
> java.logging
> java.management
> java.management.rmi
> java.naming
> java.net.http
> java.prefs
> java.rmi
> java.scripting
> java.sql
> java.sql.rowset
> java.xml
> jdk.jartool
> jdk.javadoc
> jdk.jcmd
> jdk.jconsole
> jdk.management.agent
> jdk.naming.dns
> jdk.rmic
>
>
> Webrev:
> http://cr.openjdk.java.net/~rriggs/webrev-string-isempty-8214971-1/
>
> Issue:
> https://bugs.openjdk.java.net/browse/JDK-8214971
>
> Thanks, Roger
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
More information about the core-libs-dev
mailing list