[12] (AIX) 8207744: Clean up inconsistent use of opendir/closedir versus opendir64/closedir64

[B. Blaser]

Hi Brian,

On 26 July 2018 at 22:13, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:
> https://bugs.openjdk.java.net/browse/JDK-8207744
> http://cr.openjdk.java.net/~bpb/8207744/webrev.00/
>
> This change simply adds
>
> #if defined(_AIX)
>   #define DIR DIR64
>   #define opendir opendir64
>   #define closedir closedir64
> #endif
>
> to each of
>
> src/java.base/share/native/libjli/wildcard.c src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c src/java.base/unix/native/libjava/TimeZone_md.c
>
> If someone who builds OpenJDK on AIX would try this out that would be great as I can only verify that it does not cause problems on the platforms that we support (currently in progress).
>
> Thanks,
>
> Brian

I cannot experiment on AIX myself but as mentioned in [1], shouldn't
this also/only be necessary in 'OperatingSystemImpl.c' &
'TimeZone_md.c'?
I guess the problem on AIX is that 'readdir64' needs
'openddir64/closedir64/DIR64' while these methods don't exist and are
de-facto not necessary on Linux (at least with glibc 2.26 64-bit).
The other files you suggest to fix seem to use 'readdir' so I believe
'opendir/closedir' are well deserved here.

What do you think?

Thanks,
Bernard


[1] http://mail.openjdk.java.net/pipermail/core-libs-dev/2018-July/054439.html