[12] (AIX) 8207744: Clean up inconsistent use of opendir/closedir versus opendir64/closedir64

Brian Burkhalter brian.burkhalter at oracle.com
Fri Jul 27 20:09:11 UTC 2018


Hi Bernard,

I think you are correct. Webrev updated accordingly:

http://cr.openjdk.java.net/~bpb/8207744/webrev.01/

I know you cannot do it, but a build of this on AIX by someone would be appreciated (not urgent).

Thanks,

Brian

On Jul 27, 2018, at 7:16 AM, B. Blaser <bsrbnd at gmail.com> wrote:

> I cannot experiment on AIX myself but as mentioned in [1], shouldn't
> this also/only be necessary in 'OperatingSystemImpl.c' &
> 'TimeZone_md.c'?
> I guess the problem on AIX is that 'readdir64' needs
> 'openddir64/closedir64/DIR64' while these methods don't exist and are
> de-facto not necessary on Linux (at least with glibc 2.26 64-bit).
> The other files you suggest to fix seem to use 'readdir' so I believe
> 'opendir/closedir' are well deserved here.
> 
> What do you think?
> 
> Thanks,
> Bernard
> 
> 
> [1] http://mail.openjdk.java.net/pipermail/core-libs-dev/2018-July/054439.html



More information about the core-libs-dev mailing list