RFR: 8199471: Enable generation of callSiteForms at link time

Paul Sandoz paul.sandoz at oracle.com
Tue Mar 13 19:32:53 UTC 2018


Invokers.java
—

Looks good.

Minor comment:

 664     /* Placeholder class for Invokers generated ahead of time */
 665     final class Holder {}
 666 
 667     /* Placeholder class for callSiteForms generated ahead of time */
 668     final class CSHolder {}

is it easy for you to change, for clarity, Holder to InvokersHolder and CSHolder to CallSiteHolder?

Thanks,
Paul.


> On Mar 12, 2018, at 11:59 AM, Claes Redestad <claes.redestad at oracle.com> wrote:
> 
> Hi,
> 
> LFs generated via Invokers.callSiteForm only depend on the MethodTypeForm and link type,
> and can be generated ahead of time by jlink --generate-jli-classes:
> 
> Webrev: http://cr.openjdk.java.net/~redestad/8199471/open.00/
> Bug:    https://bugs.openjdk.java.net/browse/JDK-8199471
> 
> The current training runs done during build shows this is somewhat effective at reducing
> the number of LF classes we generate at runtime, avoiding spinning up up to 6 classes
> during bootstrap.
> 
> Thanks!
> 
> /Claes



More information about the core-libs-dev mailing list