RFR: 8199471: Enable generation of callSiteForms at link time
Claes Redestad
claes.redestad at oracle.com
Wed Mar 14 14:09:33 UTC 2018
Hi Paul,
On 2018-03-13 20:32, Paul Sandoz wrote:
> Invokers.java
> —
>
> Looks good.
Thanks!
>
> Minor comment:
>
> 664 /* Placeholder class for Invokers generated ahead of time */
> 665 final class Holder {}
> 666
> 667 /* Placeholder class for callSiteForms generated ahead of time */
> 668 final class CSHolder {}
>
> is it easy for you to change, for clarity, Holder to InvokersHolder and CSHolder to CallSiteHolder?
I instead took a stab at consolidating these two holder classes into one,
and instead of unnecessarily complicating the code (as I had feared), it
actually reduced duplicated code, only slightly complicated one of
the helper methods and made the patch smaller overall:
http://cr.openjdk.java.net/~redestad/8199471/open.01/
/Claes
More information about the core-libs-dev
mailing list