8203487: Typo in ICUBinary.java: s/Magin/Magic/

Naoto Sato naoto.sato at oracle.com
Mon May 21 18:23:14 UTC 2018


+1

Naoto

On 5/21/18 10:00 AM, Ivan Gerasimov wrote:
> Looks good!
> 
> With kind regards,
> 
> Ivan
> 
> 
> On 5/21/18 9:57 AM, Brian Burkhalter wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8203487
>>
>> --- a/src/java.base/share/classes/sun/text/normalizer/ICUBinary.java
>> +++ b/src/java.base/share/classes/sun/text/normalizer/ICUBinary.java
>> @@ -255,7 +255,7 @@
>>       * Error messages
>>       */
>>       private static final String MAGIC_NUMBER_AUTHENTICATION_FAILED_ =
>> -                       "ICUBinary data file error: Magin number 
>> authentication failed";
>> +                       "ICUBinary data file error: Magic number 
>> authentication failed";
>>       private static final String HEADER_AUTHENTICATION_FAILED_ =
>>           "ICUBinary data file error: Header authentication failed";
>>   }
>>
>> Thanks,
>>
>> Brian
>>
>> On May 21, 2018, at 9:50 AM, Brian Burkhalter 
>> <brian.burkhalter at oracle.com> wrote:
>>
>>> Hi Adam,
>>>
>>> I’ll take it.
>>>
>>> Thanks,
>>>
>>> Brian
>>>
>>> On May 21, 2018, at 9:01 AM, Adam Farley8 <adam.farley at uk.ibm.com> 
>>> wrote:
>>>
>>>> There's a typo here on line 258, where is says "Magin number" but means
>>>> "Magic number".
>>>>
>>>> http://hg.openjdk.java.net/jdk/jdk/file/ec881a19d294/src/java.base/share/classes/sun/text/normalizer/ICUBinary.java 
>>>>
>>>>
>>>>
>>>> Can a committer review and correct the typo?
>>
> 


More information about the core-libs-dev mailing list