8203487: Typo in ICUBinary.java: s/Magin/Magic/
Adam Farley8
adam.farley at uk.ibm.com
Tue May 22 08:16:45 UTC 2018
Very quick. Thanks all. :)
- Adam
> +1
>
> Naoto
>
> On 5/21/18 10:00 AM, Ivan Gerasimov wrote:
> > Looks good!
> >
> > With kind regards,
> >
> > Ivan
> >
> >
> > On 5/21/18 9:57 AM, Brian Burkhalter wrote:
> >>
https://bugs.openjdk.java.net/browse/JDK-8203487
> >>
> >> --- a/src/java.base/share/classes/sun/text/normalizer/ICUBinary.java
> >> +++ b/src/java.base/share/classes/sun/text/normalizer/ICUBinary.java
> >> @@ -255,7 +255,7 @@
> >> Â Â Â Â Â * Error messages
> >> Â Â Â Â Â */
> >> Â Â Â Â Â private static final String
MAGIC_NUMBER_AUTHENTICATION_FAILED_ =
> >> -Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â "ICUBinary data file
error: Magin number
> >> authentication failed";
> >> +Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â "ICUBinary data file
error: Magic number
> >> authentication failed";
> >> Â Â Â Â Â private static final String HEADER_AUTHENTICATION_FAILED_
=
> >> Â Â Â Â Â Â Â Â Â "ICUBinary data file error: Header authentication
failed";
> >> Â }
> >>
> >> Thanks,
> >>
> >> Brian
> >>
> >> On May 21, 2018, at 9:50 AM, Brian Burkhalter
> >> <brian.burkhalter at oracle.com> wrote:
> >>
> >>> Hi Adam,
> >>>
> >>> IÂ’ll take it.
> >>>
> >>> Thanks,
> >>>
> >>> Brian
> >>>
> >>> On May 21, 2018, at 9:01 AM, Adam Farley8 <adam.farley at uk.ibm.com>
> >>> wrote:
> >>>
> >>>> There's a typo here on line 258, where is says "Magin number" but
means
> >>>> "Magic number".
> >>>>
> >>>>
http://hg.openjdk.java.net/jdk/jdk/file/ec881a19d294/src/java.base/share/classes/sun/text/normalizer/ICUBinary.java
> >>>>
> >>>>
> >>>>
> >>>> Can a committer review and correct the typo?
> >>
> >
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number
741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
More information about the core-libs-dev
mailing list