RFR : 8211106: [windows] Update OS detection code to recognize Windows Server 2019
Bob Vandette
bob.vandette at oracle.com
Tue Oct 2 14:09:18 UTC 2018
Matthias,
We don’t usually add logic to the JDK related to unreleased operating system previews.
Has the ReleaseID been updated on the system you are testing on?
This is the documented way of determining the OS version you are running on?
The latest preview release is build 17744. Are you testing on that release?
https://techcommunity.microsoft.com/t5/Windows-Server-Insiders/Windows-Server-2019-version-info/td-p/234472
Bob.
> On Oct 2, 2018, at 9:01 AM, Baesken, Matthias <matthias.baesken at sap.com> wrote:
>
> Hello, please review change 8211106 .
>
> It updates the Windows OS detection code to recognize Windows Server 2019 .
>
> For this we have to look at the build number (dwBuildNumber of OSVERSIONINFOEX),
>
> https://docs.microsoft.com/en-us/windows/desktop/api/Winnt/ns-winnt-_osversioninfoexa
>
>
> because dwMajorVersion and dwMinorVersion are the same for Windows server 2016 and 2019 .
>
> The build number used to compare ( 17677 ) is for Windows Server 2019 preview , most likely the final version will have a higher build number but this is fine for the coding .
>
>
> Bug/webrev :
>
> https://bugs.openjdk.java.net/browse/JDK-8211106
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8211106.0/webrev/
>
>
> Thanks, Matthias
More information about the core-libs-dev
mailing list