RFR JDK-8210899: (zipfs) ZipFileSystem.EntryOutputStreamCRC32 mistakenly set the crc32 value into size field

Brian Burkhalter brian.burkhalter at oracle.com
Wed Sep 19 00:50:21 UTC 2018


Hi Sherman,

This looks fine to me.

Does the current code fail both of the added checks in the test?

Thanks,

Brian

On Sep 18, 2018, at 5:14 PM, Xueming Shen <xueming.shen at oracle.com> wrote:

> Please help codereview the change for JDK-8210899.
> 
> issue: https://bugs.openjdk.java.net/browse/JDK-8210899
> webrev: http://cr.openjdk.java.net/~sherman/8210899/webrev



More information about the core-libs-dev mailing list