RFR JDK-8210899: (zipfs) ZipFileSystem.EntryOutputStreamCRC32 mistakenly set the crc32 value into size field

Xueming Shen xueming.shen at oracle.com
Wed Sep 19 01:45:36 UTC 2018


On 9/18/18, 5:50 PM, Brian Burkhalter wrote:
> Hi Sherman,
>
> This looks fine to me.
>
> Does the current code fail both of the added checks in the test?

Hi Brian,

Thanks looking into it.

Yes, the current code (with the change for JDK-8034802) fails both of 
the added
checks.

Thanks,
Shermzn



>
> Thanks,
>
> Brian
>
> On Sep 18, 2018, at 5:14 PM, Xueming Shen <xueming.shen at oracle.com 
> <mailto:xueming.shen at oracle.com>> wrote:
>
>> Please help codereview the change for JDK-8210899.
>>
>> issue:https://bugs.openjdk.java.net/browse/JDK-8210899
>> webrev:http://cr.openjdk.java.net/~sherman/8210899/webrev 
>> <http://cr.openjdk.java.net/%7Esherman/8210899/webrev>
>



More information about the core-libs-dev mailing list