RFR(M) : 8211171 : move JarUtils to top-level testlibrary
Alan Bateman
Alan.Bateman at oracle.com
Sun Sep 30 15:00:32 UTC 2018
On 27/09/2018 00:38, Igor Ignatyev wrote:
> here is the webrevs w/ JarUtils from default package inserted into
> jdk.test.lib.util.JarUtils:
> whole patch:
> http://cr.openjdk.java.net/~iignatyev//8211171/webrev.01/index.html
> <http://cr.openjdk.java.net/%7Eiignatyev//8211171/webrev.01/index.html>
>> 655 lines changed: 239 ins; 355 del; 61 mod;
> incremental:
> http://cr.openjdk.java.net/~iignatyev//8211171/webrev.0-1/index.html
> <http://cr.openjdk.java.net/%7Eiignatyev//8211171/webrev.0-1/index.html>
>> 476 lines changed: 239 ins; 203 del; 34 mod;
>
> doing that, I noticed that both updateJarFile and createJarFile don't
> close Stream<Path> from Files::find, the current patch fixes that.
>
I see you've also deprecated the String methods in the old class - good!
I'd probably carry over test/jdk/lib/testlibrary/JarUtils.java without
changing the format but your IDE must be setup differently and it will
get changed again by whoever next changes it so I think it's okay.
The update to tests using this look fine.
-Alan
More information about the core-libs-dev
mailing list