RFR: 8229485: Add decrementExact(), incrementExact(), and negateExact() to java.lang.StrictMath

Joe Wang huizhe.wang at oracle.com
Wed Aug 14 19:15:23 UTC 2019


> while you're here, could you please replace semicolon with comma:
>  916      * Returns the value of the {@code long} argument;
>  917      * throwing an exception if the value overflows an {@code int}.

It seems to me the first sentence shall be the synopsis. The 2nd part is 
not necessary as that's what the "@throws" tag is for. If it has to be 
there, should it be "throws" instead of "throwing" (I'm not a native 
speaker :-) )

Cheers,
Joe

>
> With kind regards,
> Ivan
>
>
> On 8/14/19 9:01 AM, Julia Boes wrote:
>>
>> Hi,
>>
>> This fix adds decrementExact(), incrementExact(), and negateExact() 
>> to java.lang.StrictMath. The methods were added to java.lang.Math 
>> previously [1] and should have been added to java.lang.StrictMath for 
>> consistency.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8229485
>>
>> Webrev: http://cr.openjdk.java.net/~dfuchs/jboes/8229485/webrev.01/
>>
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8229702
>>
>> Thanks,
>>
>> Julia
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8022109
>>
>>



More information about the core-libs-dev mailing list