RFR: JDK-8215381: Investigate if current implementation of --license-file is correct for Debian packages

Alexey Semenyuk alexey.semenyuk at oracle.com
Mon Aug 19 23:22:59 UTC 2019


There is a bunch or resource names with "deb-" prefix. My assumption 
about this prefix was that these names are related to control files for 
Debian packaging, i.e. special files that go into DEBIAN directory. 
copyright file used to be one of them. However this was not correct. 
There should be no DEBIAN/copyright file at all. Instead copyright file 
should be installed at /usr/share/doc/<package>/copyright location. To 
reflect this change I removed "deb-" prefix.
There is param.license-type.default resource name that is RPM specific, 
so I don't think there is any inconsistency.

- Alexey

On 8/19/2019 5:54 PM, Kevin Rushforth wrote:
> Looks good. I do have one question. I see that you changed the 
> resource name from "resource.deb-copyright" to 
> "resource.copyright-file". Will this property be used for the RPM 
> copyright / license file, too? If not, would it be better to keep 
> "deb" in the name?
>
> -- Kevin
>
>
> On 8/19/2019 9:25 AM, Alexey Semenyuk wrote:
>> Please review the jpackage fix for bug [1] at [2].
>>
>> This is a fix for the JDK-8200758-branch branch of the open sandbox 
>> repository (jpackage).
>>
>> - change format of the default copyright file to comply with Debian 
>> packaging requirements;
>> - install copyright file in proper location to comply with Debian 
>> packaging requirements;
>> - introduce --linux-deb-copyright-file command line option to allow 
>> override of the default copyright file template
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8215381
>>
>> [2] http://cr.openjdk.java.net/~asemenyuk/8215381/webrev.00/
>>
>> Thanks,
>> Alexey
>>
>



More information about the core-libs-dev mailing list