RFR: JDK-8233270: Add support to jtreg helpers to unpack packages

Andy Herrick andy.herrick at oracle.com
Fri Dec 6 18:55:56 UTC 2019


The changes look good to me.

/Andy

On 12/6/2019 12:55 PM, Alexey Semenyuk wrote:
> Initially the work was focused on [2] issue to fix icons assignment 
> for launchers created by jpackage.
> In the process of working on the fix for [2] it turned out jpackage 
> test framework was lacking functionality to cover the fix in an 
> environment where installation of packages produced by jpackage is not 
> possible. This gap was filled with the patch for [1].
> The amount of work to fix [1] outweighed [2], so [1] became primary 
> fix in this bundle.
>
> Fixes can be decoupled and pushed as an independent patches. This will 
> require extra effort though. Would this be a better option?
>
> - Alexey
>
> On 12/5/2019 8:33 PM, Philip Race wrote:
>> I don't understand the relationship between these two bugs.
>>
>> -phil
>>
>> On 12/5/19, 2:47 PM, Alexey Semenyuk wrote:
>>> Please review  fixes for [1] and [2]. Both target jpackage tool.
>>>
>>> The webrev is at [3].
>>>
>>> [1] https://bugs.openjdk.java.net/browse/JDK-8233270
>>>
>>> [2] https://bugs.openjdk.java.net/browse/JDK-8230933
>>>
>>> [3] http://cr.openjdk.java.net/~asemenyuk/8233270/webrev.00/
>>>
>


More information about the core-libs-dev mailing list