RFR: 8210469: Missing doPriviledged block and permission for jdk.zipfs module

Jonathan Gibbons jonathan.gibbons at oracle.com
Thu Jan 24 21:28:55 UTC 2019


Hi Lance,

Stylistically, putting the comma at the beginning of line 327 looks ... 
unusual

325 zfpath = AccessController.doPrivileged(
326 (PrivilegedExceptionAction<Path>) () -> tempPath.toRealPath()
327 , null,
328 new java.util.PropertyPermission("user.dir", "read"));

-- Jon

On 01/24/2019 12:48 PM, Lance Andersen wrote:
> Hi all,
>
> Please review the following patch which addresses https://bugs.openjdk.java.net/browse/JDK-8210469 where jdk.zipfs was missing a doPriviledged block and permission  needed when closing a zip file system when a security manager has been enabled.
>
> The webrev can be found at: http://cr.openjdk.java.net/~lancea/8210469/webrev.00/index.html
>
> Best
> Lance
>
>   <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>   <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>   <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>
>
>



More information about the core-libs-dev mailing list