RFR: 8210469: Missing doPriviledged block and permission for jdk.zipfs module

[Lance Andersen]

Hi Jon,
> On Jan 24, 2019, at 4:28 PM, Jonathan Gibbons <jonathan.gibbons at oracle.com> wrote:
> 
> Hi Lance,
> 
> Stylistically, putting the comma at the beginning of line 327 looks ... unusual
> 
> 325 zfpath = AccessController.doPrivileged(
> 326 (PrivilegedExceptionAction<Path>) () -> tempPath.toRealPath()
> 327 , null,
> 328 new java.util.PropertyPermission("user.dir", "read"));
> 

thanks for catching that, I agree, it should not be there, I think I just saw what I wanted to see. :-)

  I updated the webrev in place as there is no other change

Best
Lance
> -- Jon
> 
> On 01/24/2019 12:48 PM, Lance Andersen wrote:
>> Hi all,
>> 
>> Please review the following patch which addresses https://bugs.openjdk.java.net/browse/JDK-8210469 where jdk.zipfs was missing a doPriviledged block and permission  needed when closing a zip file system when a security manager has been enabled.
>> 
>> The webrev can be found at: http://cr.openjdk.java.net/~lancea/8210469/webrev.00/index.html
>> 
>> Best
>> Lance
>> 
>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>> Oracle Java Engineering
>> 1 Network Drive
>> Burlington, MA 01803
>> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>> 
>> 
>> 
> 

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>