RFR (s) 8225397 : Integer value miscalculation in toString() method of BitSet

Andrew Haley aph at redhat.com
Thu Jun 6 15:39:09 UTC 2019


On 6/6/19 12:35 PM, Ivan Gerasimov wrote:
> Could you please check it if it looks better now?
> 
> http://cr.openjdk.java.net/~igerasim/8225397/00/webrev/

OK, it's just a hint, fair enough. Patch is OK.

For an extra gold star (:-) you could consider adding a comment like
"avoid overflow in the case of a humongous numBits". There's no need
for another review if you do so.

-- 
Andrew Haley
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671


More information about the core-libs-dev mailing list