RFR (s) 8225397 : Integer value miscalculation in toString() method of BitSet

Ivan Gerasimov ivan.gerasimov at oracle.com
Fri Jun 7 00:22:16 UTC 2019


On 6/6/19 8:39 AM, Andrew Haley wrote:

> On 6/6/19 12:35 PM, Ivan Gerasimov wrote:
>> Could you please check it if it looks better now?
>>
>> http://cr.openjdk.java.net/~igerasim/8225397/00/webrev/
> OK, it's just a hint, fair enough. Patch is OK.
Thank you!

> For an extra gold star (:-) you could consider adding a comment like
> "avoid overflow in the case of a humongous numBits". There's no need
> for another review if you do so.
You got it!
Pushed with the suggested comment added.

With kind regards,
Ivan



More information about the core-libs-dev mailing list