RFR(S): 8221262: Cleanups in UnixFileSystem/WinNTFileSystem implementation classes

Langer, Christoph christoph.langer at sap.com
Sun Mar 24 20:26:14 UTC 2019

Hi Ivan,

thanks for looking closely.

> UnixFileSystem_md.c:
> Should the second error message be "Could not close file"?

Yes, maybe that's better. Though it's really just the fallback, one could at least distinguish the two possibilities of IOException in this method...

> UnixFileSystem.java:
> Line spacing looks inconsistent.  Please leave an empty line before
> @Override at lines 267, 269, 271, 273, etc.

Good point, I compared to WinNTFileSystem.java and aligned the line spacing.

Please find the updated webrev here:

Best regards

More information about the core-libs-dev mailing list