RFR(S): 8221262: Cleanups in UnixFileSystem/WinNTFileSystem implementation classes

Ivan Gerasimov ivan.gerasimov at oracle.com
Mon Mar 25 17:29:35 UTC 2019


Looks good, thank you!

With kind regards,
Ivan

On 3/24/19 1:26 PM, Langer, Christoph wrote:
> Hi Ivan,
>
> thanks for looking closely.
>
>> UnixFileSystem_md.c:
>> Should the second error message be "Could not close file"?
> Yes, maybe that's better. Though it's really just the fallback, one could at least distinguish the two possibilities of IOException in this method...
>
>> UnixFileSystem.java:
>> Line spacing looks inconsistent.  Please leave an empty line before
>> @Override at lines 267, 269, 271, 273, etc.
> Good point, I compared to WinNTFileSystem.java and aligned the line spacing.
>
> Please find the updated webrev here:
> http://cr.openjdk.java.net/~clanger/webrevs/8221262.1/
>
> Best regards
> Christoph
>
>

-- 
With kind regards,
Ivan Gerasimov



More information about the core-libs-dev mailing list