RFR: 8231863: Crash if classpath is read from @argument file and the main gets option argument

Alan Bateman Alan.Bateman at oracle.com
Mon Nov 11 18:24:56 UTC 2019


On 11/11/2019 16:53, Henry Jen wrote:
> Thanks Alan and Mandy for the review.
>
> I am guessing the Alan’s preference to use Files.write(aFilePath, lines) is to avoid extra String.join operation, which I would too. The current version with byte[] is more flexible but we most likely won't need it in launcher. Anyway, I don’t think the difference would be noticeable with launcher tests.
>
The update looks good (and should avoid others tripping up on the subtly 
of the last line).

-Alan


More information about the core-libs-dev mailing list