RFR: 8231863: Crash if classpath is read from @argument file and the main gets option argument

[Mat Carter]

Thanks for the feedback, it's been a great learning experience and I'll make sure to incorporate these considerations in future contributions

Cheers
Mat


Sent from Outlook<http://aka.ms/weboutlook>

________________________________
From: Alan Bateman <Alan.Bateman at oracle.com>
Sent: Monday, November 11, 2019 10:24 AM
To: Henry Jen <henry.jen at oracle.com>; Mandy Chung <mandy.chung at oracle.com>
Cc: Mat Carter <Matthew.Carter at microsoft.com>; core-libs-dev at openjdk.java.net <core-libs-dev at openjdk.java.net>
Subject: Re: RFR: 8231863: Crash if classpath is read from @argument file and the main gets option argument

On 11/11/2019 16:53, Henry Jen wrote:
> Thanks Alan and Mandy for the review.
>
> I am guessing the Alan’s preference to use Files.write(aFilePath, lines) is to avoid extra String.join operation, which I would too. The current version with byte[] is more flexible but we most likely won't need it in launcher. Anyway, I don’t think the difference would be noticeable with launcher tests.
>
The update looks good (and should avoid others tripping up on the subtly
of the last line).

-Alan