RFR: JDK-8231910: Expose the APPDIR variable to applications that use jpackage

Alexey Semenyuk alexey.semenyuk at oracle.com
Tue Oct 8 19:33:19 UTC 2019


Andy,

AbstractAppImageBuilder.java: is extra ` + File.separator` by intention?

WinMsiBundler.java: static cache will be a potential problem if jpackage 
will be used as tool provider, i.e. in scenario when jpackage will be 
called multiple times per jvm session.

- Alexey

On 10/8/2019 3:06 PM, Andy Herrick wrote:
> Please review the jpackage fix for bug [1] at [2].
>
> This is a fix for the JDK-8200758-branch branch of the open sandbox 
> repository (jpackage).
>
> This change is to Expose the macro $APPDIR for use in --java-options 
> value, to rename macros to mean what they are called, and to eliminate 
> several unused macros.
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8231910
>
> [2] http://cr.openjdk.java.net/~herrick/8231910/
>
> /Andy
>



More information about the core-libs-dev mailing list