RFR of JDK-8209824: Improve the code coverage for ThreadLocal

Hamlin Li huaming.li at oracle.com
Tue Oct 15 03:07:31 UTC 2019


Thank you for reviewing David. I will update/push the change as you 
suggested.

BTW, sorry for the wrong bug number in email subject, it should be 8209824.

Thank you

-Hamlin

On 2019/10/15 10:29 AM, David Holmes wrote:
> Hi Hamlin,
>
> On 15/10/2019 12:03 pm, Hamlin Li wrote:
>> Could some help to review it?
>
> Basic test seems okay but a few minor suggestions:
>
> 1. Please add a public summary to the bug report to convey the same 
> information as:
>
> 27  * @summary per latest JDK code coverage report, 2 methods 
> replaceStaleEntry
>   28  *          and prevIndex in ThreadLocal.ThreadLocalMap is not 
> touched
>   29  *          by any JDK regression tests, this is to trigger the 
> code path.
>
> 2. In that comment s/is not/are not/
>
> 3. Please add a brief comment to the code explaining how the test 
> exercises the previously untested methods.
>
> No need to see an updated webrev for the above.
>
> Thanks,
> David
>
>> Thank you
>>
>> -Hamlin
>>
>> On 2019/9/4 3:16 PM, Hamlin Li wrote:
>>> Would you please review the following patch?
>>>
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8209824
>>>
>>> webrev: http://cr.openjdk.java.net/~mli/8209824/webrev.00/
>>>
>>>
>>> Thank you
>>>
>>> -Hamlin
>>>


More information about the core-libs-dev mailing list