RFR 8231451: ZipFileInputStream::skip handling of negative values with STORED entries

Alan Bateman Alan.Bateman at oracle.com
Tue Oct 22 18:37:32 UTC 2019


On 22/10/2019 18:00, Lance Andersen wrote:
>
> Per your suggestion, I tweaked the patch to move to BOF when the 
> negative skip value goes beyond BOF.  I updated the release note as well.
>
> webrev can be found at: 
> http://cr.openjdk.java.net/~lancea/8231451/webrev.01/index.html
>
I assume skip(Long.MAX_VALUE) will cause n+pos to overflow and it will 
skip backwards rather than to the end. It might be simpler to read/audit 
if you separate the negative skip case.

-Alan


More information about the core-libs-dev mailing list