RFR 8231451: ZipFileInputStream::skip handling of negative values with STORED entries

[Lance Andersen]

> On Oct 22, 2019, at 2:37 PM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> 
> On 22/10/2019 18:00, Lance Andersen wrote:
>> 
>> Per your suggestion, I tweaked the patch to move to BOF when the negative skip value goes beyond BOF.  I updated the release note as well.
>> 
>> webrev can be found at: http://cr.openjdk.java.net/~lancea/8231451/webrev.01/index.html
>> 
> I assume skip(Long.MAX_VALUE) will cause n+pos to overflow and it will skip backwards rather than to the end.

That is correct.  If you prefer it to skip to the end, I will adjust accordingly.
> It might be simpler to read/audit if you separate the negative skip case.
I can do that as well.

Best
Lance
> 
> -Alan

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>