RFR: 8232864: Classes generated by GenerateJLIClassesPlugin.java are not reproducable

[Mandy Chung]

Hi Jie,

The new test looks good, thanks.

About the GenerateJLIClassesPlugin change, I mentioned the alternative 
way to implement it.   I think you can avoid the resorting in the case 
when the trace config file is present.   I'd like to see the initialize 
method builds a sorted speciesTypes, invokerTypes, callSiteTypes and 
dmhMethods.   The readTraceConfig method already creates them as 
TreeMap/TreeSet.   Some refactoring or using a builder class should 
achieve this.

Mandy

On 10/23/19 9:04 PM, Jie Fu wrote:
>
> Hi Mandy,
>
> Updated: http://cr.openjdk.java.net/~jiefu/8232864/webrev.01/
>
> The JLinkReproducibleTest had been extended to test the case when the 
> default trace file is not present.
>
> If you're OK with the change, could you please sponsor it?
>
> Thanks a lot.
> Best regards,
> Jie
>
> On 2019/10/24 上午2:37, Mandy Chung wrote:
>> Can you also extend JLinkReproducibleTest to add the case when
>> the default trace config is not present?