RFR: 8232864: Classes generated by GenerateJLIClassesPlugin.java are not reproducable

Jie Fu fujie at loongson.cn
Thu Oct 24 06:21:28 UTC 2019


Hi Mandy,

Updated: http://cr.openjdk.java.net/~jiefu/8232864/webrev.02/
It seems better now.

If you're OK with the change, could you please sponsor it?

Thanks a lot.
Best regards,
Jie

On 2019/10/24 下午1:12, Mandy Chung wrote:
> About the GenerateJLIClassesPlugin change, I mentioned the alternative 
> way to implement it.   I think you can avoid the resorting in the case 
> when the trace config file is present.   I'd like to see the 
> initialize method builds a sorted speciesTypes, invokerTypes, 
> callSiteTypes and dmhMethods.   The readTraceConfig method already 
> creates them as TreeMap/TreeSet.   Some refactoring or using a builder 
> class should achieve this. 

Very cool suggestions. Thanks.

Done.




More information about the core-libs-dev mailing list