RFR: JDK-8230522: rename "--linux-bundle-name", and "--temp-root" options.

[Andy Herrick]

On 9/9/2019 6:31 PM, Alexander Matveev wrote:
> Hi Andy,
>
> http://cr.openjdk.java.net/~herrick/8230522/webrev.01/src/jdk.jpackage/linux/classes/jdk/jpackage/internal/resources/LinuxResources.properties.frames.html 
>
> Line 44 "mp." -> "map"
This is a typo I will fix.
>
> http://cr.openjdk.java.net/~herrick/8230522/webrev.01/src/jdk.jpackage/share/classes/jdk/jpackage/internal/Arguments.java.frames.html 
>
> Do we want to rename internal names like MAC_BUNDLE_NAME  -> 
> MAC_PACKAGE_NAME?

Generally, I didn't want to change anything but the CLI option name, and 
that includes the deploy parameter name used internally.

If we want a follow up issue to make all internal deploy parameter 
identifiers correspond more closely to the CLI options they reflect, I 
have no problem with that, but it would apply to a lot more than the 4-5 
options being renamed here.


> I think we should at least as follow up cleanup issue, to make code 
> less confusing with different name.
>
> Otherwise looks fine.
>
> Thanks,
> Alexander
>
> On 9/9/2019 12:15 PM, Andy Herrick wrote:
>> Please review the jpackage fix for bug [1] at [2].
>>
>> This is a fix for the JDK-8200758-branch branch of the open sandbox 
>> repository (jpackage).
>>
>> This fix:
>>
>> modifies the name of options:
>>
>> --temp-root, --linux-bundle-name , --mac-bundle-name, 
>> --mac-bundle-identifier, and --mac-bundle-signing-prefix.
>>
>> new names:
>>
>> --temp, --linux-package-name , --mac-package-name, 
>> --mac-package-identifier, and --mac-package-signing-prefix.
>>
>> This change also also removes the period at the end of all error 
>> messages.
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8230522
>> [2] http://cr.openjdk.java.net/~herrick/8230522
>>
>> Thanks
>>
>> Andy,
>>
>