RFR: 8231186: Replace html tag <code>foo</code> with javadoc tag {@code foo} in java.base

naoto.sato at oracle.com naoto.sato at oracle.com
Wed Sep 18 18:32:46 UTC 2019


Hi Julia,

This is not a comment to changes you've made, but the webrev seems 
missing some diffs, e.g.,

http://cr.openjdk.java.net/~jboes/webrevs/8231186/webrev.02/src/java.base/share/classes/java/util/Calendar.java.sdiff.html
http://cr.openjdk.java.net/~jboes/webrevs/8231186/webrev.02/src/java.base/share/classes/java/util/ResourceBundle.java.sdiff.html

Not checked all, so there may be some other blank diffs. Could be a bug 
in the tool.

Naoto

On 9/18/19 8:47 AM, Julia Boes wrote:
> Hi,
> 
> This change replaces the HTML code tag with the equivalent javadoc tag 
> in the java.base module as such:
> 
> <code>foo</code> becomes {@code foo}
> 
> Ignored are any code tags that enclose other HTML or javadoc tags or 
> that contain HTML entities, e.g. character codes.
> 
> 
> Examples (after change):
> 
> java.base/share/classes/java/nio/charset/spi/CharsetProvider.java
> 
> 51 * ignored.  The comment character is {@code '#'} 
> (<code>'\u0023'</code>); on
> 
> java.base/share/classes/java/io/File.java
> 
> 625 * <code>new File(this.{@link #getCanonicalPath})</code>.
> 
> 
> I reviewed the change with specdiff and doccheck on the java.base 
> module, neither flagged any differences or errors. I also reviewed the 
> javadoc of some classes manually but did not do an extensive manual review.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8231186
> 
> Webrev: http://cr.openjdk.java.net/~jboes/webrevs/8231186/webrev.02/
> 
> 
> The copyright year will be updated before generating the changeset.
> 
> Regards,
> 
> Julia
> 


More information about the core-libs-dev mailing list