RFR: 8243453: Option --describe-module failed with non-ASCII module name under non-UTF8 environment
Alan Bateman
Alan.Bateman at oracle.com
Fri Apr 24 08:50:39 UTC 2020
On 24/04/2020 09:33, Toshio 5 Nakamura wrote:
> Hi all,
>
> Please review this fix.
> Also, I'd like to ask a sponsor of the fix, since I'm not a committer.
>
> Issue: https://bugs.openjdk.java.net/browse/JDK-8243453
> Webrev: http://cr.openjdk.java.net/~tnakamura/8243453/webrev.00/
>
> Under Windows Japanese or Chinese, encoding of command line option
> cannot be assumed as UTF-8.
> This fix changes from "(*env)->NewStringUTF()" to "NewPlatformString()"
> to call Helper method.
>
This looks correct to me (and apologies for this bug, I don't know why I
used NewStringUTF when adding this option in JDK 9).
-Alan.
More information about the core-libs-dev
mailing list