RFR: 8243453: Option --describe-module failed with non-ASCII module name under non-UTF8 environment

[Toshio 5 Nakamura]

Hi Alan,

Thank you for the review. May I ask your help for sponsoring this fix?

Best Regards,
Toshio Nakamura

Alan Bateman <Alan.Bateman at oracle.com> wrote on 2020/04/24 17:50:39:

> On 24/04/2020 09:33, Toshio 5 Nakamura wrote:
> > Hi all,
> >
> > Please review this fix.
> > Also, I'd like to ask a sponsor of the fix, since I'm not a committer.
> >
> > Issue:
https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8243453&d=DwICaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=EVbFABcgo-X99_TGI2-qsMtyulHUruf8lAzMlVpVRqw&m=cT0541m2fenmr7m1ceVW_jsLw9PFcETHyrVZmBIBT7I&s=2MCap8HFtEpR-ewTpkte08Ae4EKczAH07RvscWGqU6g&e=

> > Webrev:
https://urldefense.proofpoint.com/v2/url?u=http-3A__cr.openjdk.java.net_-7Etnakamura_8243453_webrev.00_&d=DwICaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=EVbFABcgo-X99_TGI2-qsMtyulHUruf8lAzMlVpVRqw&m=cT0541m2fenmr7m1ceVW_jsLw9PFcETHyrVZmBIBT7I&s=gzf38aY-kf9TZz9Ehd_8mqgr3KEkfVAdP9rVO0T8Fro&e=

> >
> > Under Windows Japanese or Chinese, encoding of command line option
> > cannot be assumed as UTF-8.
> > This fix changes from "(*env)->NewStringUTF()" to "NewPlatformString()"
> > to call Helper method.
> >
> This looks correct to me (and apologies for this bug, I don't know why I
> used NewStringUTF when adding this option in JDK 9).
>
> -Alan.
>