RFR: 8166026: refactor shell tests to java

Ivan Šipka isipka at openjdk.java.net
Wed Dec 2 20:27:58 UTC 2020


On Mon, 30 Nov 2020 21:36:40 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:

>> @iignatev  could you please review? Thank you.
>> 
>> note to self:
>> jtreg test/jdk/java/lang/ProcessBuilder/InheritIO/InheritIoTest.java test/jdk/java/lang/SecurityManager/modules/CustomSecurityManagerTest.java test/jdk/java/lang/Thread/uncaughtexceptions/UncaughtExceptionsTest.java test/jdk/java/lang/annotation/loaderLeak/LoaderLeakTest.java
>
> test/jdk/java/lang/annotation/loaderLeak/LoaderLeakTest.java line 53:
> 
>> 51:         Files.createDirectories(REPOSITORY_PATH);
>> 52:         List<String> classes = List.of("A.class", "B.class", "C.class");
>> 53:         for (String fileName : classes) {
> 
> is this really needed for the test to operate correctly? or can we just use _regular_ `TEST_CLASSES` as CP?

CLASSES_PATH is initialized with value of TEST_CLASSES property. It is obviously confusing variable naming so in the [new PR](https://github.com/openjdk/jdk/pull/1577) it is renamed

-------------

PR: https://git.openjdk.java.net/jdk/pull/1484


More information about the core-libs-dev mailing list