RFR: 8166026: refactor shell tests to java

Ivan Šipka isipka at openjdk.java.net
Wed Dec 2 20:33:56 UTC 2020


On Mon, 30 Nov 2020 21:32:35 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:

>> @iignatev  could you please review? Thank you.
>> 
>> note to self:
>> jtreg test/jdk/java/lang/ProcessBuilder/InheritIO/InheritIoTest.java test/jdk/java/lang/SecurityManager/modules/CustomSecurityManagerTest.java test/jdk/java/lang/Thread/uncaughtexceptions/UncaughtExceptionsTest.java test/jdk/java/lang/annotation/loaderLeak/LoaderLeakTest.java
>
> test/jdk/java/lang/Thread/uncaughtexceptions/UncaughtExceptionsTest.java line 70:
> 
>> 68:         outputAnalyzer.shouldHaveExitValue(exitValue);
>> 69:         outputAnalyzer.stderrShouldMatch(stdErrMatch);
>> 70:         outputAnalyzer.stdoutShouldMatch(stdOutMatch);
> 
> why do you use `ShouldMatch` and not `ShouldContain` here?

Because the first two test input tuples are regular expressions, please see [new PR](https://github.com/openjdk/jdk/pull/1578)

-------------

PR: https://git.openjdk.java.net/jdk/pull/1484


More information about the core-libs-dev mailing list