RFR: 8256515: javax.xml.XMLEventReader produces incorrect START_DOCUMENT event

[Severin Gehwolf]

On Thu, 19 Nov 2020 16:34:36 GMT, Marius Volkhart <github.com+1709517+MariusVolkhart at openjdk.org> wrote:

>> @MariusVolkhart I'll work with you getting the fix in and get the test running using jtreg. Give me a few moments to reproduce.
>
> Thanks @jerboaa 
> 
> I have a JBS number now: [8256515](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8256515). Since opening the PR I've learned that I've gone about the process backwards, and should have found a Sponsor before making the PR. As such, I haven't updated the commit message to avoid sending a premature RFR to the mailing list

@MariusVolkhart I think doing a PR is fine before you find a sponsor provided you're fairly certain it's an actual bug. It'll require one to then send an email to the mailing lists asking for a sponsor. That email could potentially reference a PR. That should be fine. The sponsor (committer) will then help you get it integrated. It somewhat depends on the issue. No hard-and-fast rules that I'm aware of in that regard.

@MariusVolkhart Here is a PR for your branch so the test works with jtreg:
https://github.com/MariusVolkhart/jdk/pull/1

Fails before the JDK patch and passes after.

Run it with:
$ rm -rf JTwork JTreport && jtreg -jdk:./build/linux-x86_64-server-release/images/jdk -verbose:summary test/jdk/javax/xml/jaxp/8256515/XmlInputFactoryTest.java
Passed: javax/xml/jaxp/8256515/XmlInputFactoryTest.java
Test results: passed: 1
Results are in *.jtr files:

$ find JTwork/ -name *.jtr
JTwork/javax/xml/jaxp/8256515/XmlInputFactoryTest.jtr

Or using the test framework of OpenJDK with:

$ bash configure --with-jtreg=/path/to/jtreg [...]
$ make test TEST="jdk/javax/xml/jaxp/8256515/XmlInputFactoryTest.java"

HTH

-------------

PR: https://git.openjdk.java.net/jdk/pull/1056