RFR: 8256515: javax.xml.XMLEventReader produces incorrect START_DOCUMENT event

Marius Volkhart github.com+1709517+mariusvolkhart at openjdk.java.net
Thu Dec 3 14:47:05 UTC 2020


On Fri, 20 Nov 2020 11:41:53 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Thanks @jerboaa 
>> 
>> I have a JBS number now: [8256515](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8256515). Since opening the PR I've learned that I've gone about the process backwards, and should have found a Sponsor before making the PR. As such, I haven't updated the commit message to avoid sending a premature RFR to the mailing list
>
> @MariusVolkhart Here is a PR for your branch so the test works with jtreg:
> https://github.com/MariusVolkhart/jdk/pull/1
> 
> Fails before the JDK patch and passes after.
> 
> Run it with:
> $ rm -rf JTwork JTreport && jtreg -jdk:./build/linux-x86_64-server-release/images/jdk -verbose:summary test/jdk/javax/xml/jaxp/8256515/XmlInputFactoryTest.java
> Passed: javax/xml/jaxp/8256515/XmlInputFactoryTest.java
> Test results: passed: 1
> Results are in *.jtr files:
> 
> $ find JTwork/ -name *.jtr
> JTwork/javax/xml/jaxp/8256515/XmlInputFactoryTest.jtr
> 
> Or using the test framework of OpenJDK with:
> 
> $ bash configure --with-jtreg=/path/to/jtreg [...]
> $ make test TEST="jdk/javax/xml/jaxp/8256515/XmlInputFactoryTest.java"
> 
> HTH

@jerboaa Thanks! That PR was immensely helpful, not just in helping get this change moving, but in helping me understand how to write the tests for next time!

-------------

PR: https://git.openjdk.java.net/jdk/pull/1056


More information about the core-libs-dev mailing list