RFR: 8166026: Refactor java/lang shell tests to java [v2]

Roger Riggs rriggs at openjdk.java.net
Thu Dec 3 23:40:56 UTC 2020


On Thu, 3 Dec 2020 23:07:25 GMT, Ivan Šipka <isipka at openjdk.org> wrote:

>> Ivan Šipka has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8166026: Refactor java/lang shell tests to java
>
> test/jdk/java/lang/Thread/UncaughtExceptionsTest.java line 94:
> 
>> 92:     final static String EXPECTED_RESULT = "OK";
>> 93: 
>> 94:     public static void seppuku() { throw new RuntimeException("Seppuku!"); }
> 
> @RogerRiggs I suggest method name instead of `seppuku` to be `throwRuntimeException`?
> And to remove the message from the exception constructor.

Both suggestions work for me.  Thanks

-------------

PR: https://git.openjdk.java.net/jdk/pull/1578


More information about the core-libs-dev mailing list