RFR 8235699 : ArrayIndexOutOfBoundsException in CalendarBuilder.toString
verghese at amazon.com
Tue Feb 4 18:48:21 UTC 2020
A Reminder for review.
On 1/2/20, 1:18 PM, "Verghese, Clive" <verghese at amazon.com> wrote:
Thanks for the feedback,
I have removed the @Author tag and updated the tests as per your recommendation.
On 1/2/20, 11:19 AM, "Volker Simonis" <simonisv at amazon.de> wrote:
On 02.01.20 18:39, Alan Bateman wrote:
> On 02/01/2020 13:26, Volker Simonis wrote:
>> Ready to push?
> You shouldn't need to use core reflection here. Instead you can create
> the test so that it is compiled and runs as if part of the java.text
> package, e.g.
> @build java.base/java.text.CalendarBuilderToStringTest
> @main Driver
Thanks for the hint. I wasn't aware of this possibility.
I think Clive will rewrite the test.
> Do you really want the @author tag? We try to avoid them if possible
> because they are so hard to remove, even when code/tests are changed
No not really. It was just a part of the template I used :)
@Clive: please feel free to remove the author tag.
More information about the core-libs-dev