RFR: 8238773: Miscellaneous ODR violations in UNIX native code

Andrew Haley aph at redhat.com
Thu Feb 13 12:53:46 UTC 2020


On 2/10/20 4:44 PM, Andrew Haley wrote:
> In a couple of places variables are defined in header files, leading
> to violations of the One Definition Rule. This is not Standard C and
> breaks the build on modern compilers which complain.
> 
> http://cr.openjdk.java.net/~aph/8238773/

I withdraw this: it overlapped with

8238386: (sctp) jdk.sctp/unix/native/libsctp/SctpNet.c "multiple definition" link errors with GCC10

and

8238380: java.base/unix/native/libjava/childproc.c "multiple definition" link errors with GCC10

which fixed the same bugs in exactly the same way.

-- 
Andrew Haley  (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671



More information about the core-libs-dev mailing list