8238953: tools/jpackage tests do not work on Ubuntu Linux

Langer, Christoph christoph.langer at sap.com
Tue Feb 18 15:56:21 UTC 2020


Hi Matthias,

Looks good to me now.

Cheers
Christoph

> -----Original Message-----
> From: Baesken, Matthias <matthias.baesken at sap.com>
> Sent: Dienstag, 18. Februar 2020 16:55
> To: Langer, Christoph <christoph.langer at sap.com>; core-libs-
> dev at openjdk.java.net; Alexey Semenyuk <alexey.semenyuk at oracle.com>
> Subject: RE: 8238953: tools/jpackage tests do not work on Ubuntu Linux
> 
> Ok why not,  new webrev :
> 
> http://cr.openjdk.java.net/~mbaesken/webrevs/8238953.2/
> 
> Thanks, Matthias
> 
> 
> 
> >
> > Hi Matthias,
> >
> > you could improve the patch a bit by starting TKit:: isUbuntu() with
> >
> > if (!isLinux()) {
> >     return false;
> > }
> >
> > And then, in PackageType, you could simply do:
> >
> > private final static Set<String> DISABLED_PACKAGERS =
> Optional.ofNullable(
> >                 TKit.tokenizeConfigProperty("disabledPackagers")).orElse(
> >                 TKit.isUbuntu() ? Set.of("rpm") : Collections.emptySet());
> >
> > Best regards
> > Christoph
> >
> > > -----Original Message-----
> > > From: core-libs-dev <core-libs-dev-bounces at openjdk.java.net> On
> Behalf
> > > Of Baesken, Matthias
> > > Sent: Dienstag, 18. Februar 2020 09:14
> > > To: core-libs-dev at openjdk.java.net; Alexey Semenyuk
> > > <alexey.semenyuk at oracle.com>
> > > Subject: [CAUTION] RE: 8238953: tools/jpackage tests do not work on
> > > Ubuntu Linux
> > >
> > > Ping ...  are you fine with the latest version ?
> > >
> > > Best Regards, Matthias
> > >
> > > >
> > > > Hi Alexey  , I like your idea to do the handling in
> > > > test/jdk/tools/jpackage/helpers/jdk/jpackage/test/PackageType.java  .
> > > >
> > > > New webrev :
> > > >
> > > > http://cr.openjdk.java.net/~mbaesken/webrevs/8238953.1/
> > > >
> > > >
> > > >
> > > > Best regards, Matthias
> > > >
> > > >



More information about the core-libs-dev mailing list