RFR: JDK-8236125: Windows (MSVC 2013) build fails in jpackage: Need to include strsafe.h after tchar.h
Aleksey Shipilev
shade at redhat.com
Mon Jan 6 10:54:03 UTC 2020
On 1/6/20 10:57 AM, Alex Kashchenko wrote:
> On 12/24/2019 11:54 AM, Alex Kashchenko wrote:
>> On 12/24/2019 01:39 AM, Philip Race wrote:
>>> Have you verified this with VS 2017 ?
>>> Not that I can see a problem but I doubt we want to trade breaking
>>> 2017 to fix 2013 ...
>>
>> Yes, VS 2017 compiles fine with this fix.
>>
>>
>>> [...]
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8236125
>>> Webrev: http://cr.openjdk.java.net/~akasko/jdk/8236125/webrev.00/
>>> [...]
>
> Gentle reminder, it would be great to have this included before jdk14
> enters rampdown 2.
The patch looks good to me. (I did the same in the original bug report).
--
Thanks,
-Aleksey
More information about the core-libs-dev
mailing list