RFR: JDK-8236125: Windows (MSVC 2013) build fails in jpackage: Need to include strsafe.h after tchar.h

[Aleksey Shipilev]

On 1/7/20 7:50 AM, Aleksey Shipilev wrote:
> On 1/6/20 1:48 PM, Alex Kashchenko wrote:
>>>>>> [...]
>>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8236125
>>>>>> Webrev: http://cr.openjdk.java.net/~akasko/jdk/8236125/webrev.00/
>>>>>> [...]
>>>>
>>>> Gentle reminder, it would be great to have this included before jdk14
>>>> enters rampdown 2.
>>>
>>> The patch looks good to me. (I did the same in the original bug report).
>>
>> Thanks for the review! Sponsor is required for this patch to be pushed 
>> (I am not an author in "jdk" and cannot export committed changeset).
> 
> I can sponsor jdk/jdk14 push. But I need someone else to acknowledge (I don't feel fancy acking
> basically my own patch :]). Phil, maybe?

Actually, since jdk14 is in RDP1, we need a special approval to push, as per JEP 3
(https://openjdk.java.net/jeps/3). Please seek one in the JIRA comments, and that should be enough.

-- 
Thanks,
-Aleksey