RFR: 8236634: Memory Access API tests fail on 32-bit

[Maurizio Cimadamore]

Looks good - thanks!

Maurizio

On 09/01/2020 08:10, Nick Gasson wrote:
> Hi Maurizio,
>
> On 08/01/2020 18:23, Maurizio Cimadamore wrote:
>>>
>>> I'm happy to split it into two patches. One with the build/test fixes
>>> for jdk/jdk14 and another with the Unsafe and
>>> internal/foreign/Utils.java change for jdk/jdk (or panama/dev?). I
>>> think the most important change for jdk14 is the build fix for
>>> libNativeAccess.c as that causes "make test" to fail with the default
>>> warnings-as-errors.
>>
>> That seems like a good idea. Also feel free to disable the 'bad'
>> testTooBigForArrays on 32-bit platforms, so that you can get a clean
>> test run.
>
> I've done this here, the new webrev only touches files under test/* 
> and builds/runs jdk_foreign jtreg cleanly on x86_32 and arm32:
>
> http://cr.openjdk.java.net/~ngasson/8236634/webrev.1/index.html
>
> TestMemoryAlignment.java is skipped completely on 32-bit platforms for 
> now, as it needs the change to MAX_ALIGN in Utils.java.
>
> Thanks,
> Nick