RFR: JDK-8236125: Windows (MSVC 2013) build fails in jpackage: Need to include strsafe.h after tchar.h

Alan Bateman Alan.Bateman at oracle.com
Fri Jan 10 09:24:52 UTC 2020


On 10/01/2020 09:11, Aleksey Shipilev wrote:
> :
> No other takers? I would then push this trivial patch for Alex under my single review.
>
I think it's okay but would be nice if one of the jpackager maintainers 
jumped in.

I also think it would be useful to get an inventory of the Visual Studio 
versions that are in use. It's a bit annoying to have to keep the JDK 
still building on VS2013. Ditto for VS2015. Oracle engineers moved to 
VS2017 some time ago (discussed on build-dev). I don't know if anyone is 
building with VS2019 at this time. It may actually be more important to 
establish a base SDK release as it really annoying to have to 
dynamically look up symbols that aren't declared in the older header files.

-Alan


More information about the core-libs-dev mailing list