RFR 7143743: (zipfs) Potential memory leak with zip provider

Alan Bateman Alan.Bateman at oracle.com
Mon Jan 13 18:53:39 UTC 2020


On 13/01/2020 10:31, Jaikiran Pai wrote:
> Hello Christoph,
>
> Setting inodes to null sounds fine to me and as you say since its usage
> is already guarded by ensureOpen, IMO, it should be fine. I've now
> updated the patch to set inodes to null in close() and the new updated
> webrev is at https://cr.openjdk.java.net/~jpai/webrev/7143743/3/webrev/
>
This version looks good except it might be better if the comment just 
says that it clears the inodes map to allow the keys/values be GC'ed.

-Alan


More information about the core-libs-dev mailing list