RFR: JDK-8236132: Add missing properties to msi installers

Alexander Matveev alexander.matveev at oracle.com
Wed Jan 15 22:20:19 UTC 2020


Hi Alexey,

Thanks for explanation, then current patch looks fine.

Thanks,
Alexander

On 1/14/2020 11:29 PM, Alexey Semenyuk wrote:
> Alexander,
>
> Icon can be configured on jpackage command line and should not be 
> overridden in custom overrides.wxi file. This is the reason why I 
> didn't put its description in the default overrides.wxi file.
> JpIcon is just one of WiX variables to pass configuration data from 
> jpackage Java into WiX toolset.
>
> - Alexey
>
> On 1/6/2020 7:36 PM, Alexander Matveev wrote:
>> Hi Alexey,
>>
>> Can you add description for JpIcon to overrides.wxi, otherwise looks 
>> fine.
>>
>> Thanks,
>> Alexander
>>
>> On 12/20/2019 12:16 PM, Alexey Semenyuk wrote:
>>> Please review fix [2] for jpackage bug [1].
>>>
>>> Add properties to msi installers to properly display installation 
>>> location and icon of the application in the list of installed 
>>> applications.
>>>
>>> - Alexey
>>>
>>> [1] https://bugs.openjdk.java.net/browse/JDK-8236132
>>>
>>> [2] http://cr.openjdk.java.net/~asemenyuk/8236132/webrev.00
>>
>



More information about the core-libs-dev mailing list