[15] 8235792: LineNumberReader.getLineNumber() behavior is inconsistent with respect to EOF

Brian Burkhalter brian.burkhalter at oracle.com
Fri Jan 17 01:35:37 UTC 2020


This issue [1] attempts to reinstate the change for [2] which was backed out to fix [3] thereby maintaining longstanding behavior. The proposed change [4] modifies the specification to increment the line number also when EOF is encountered and is not immediately preceded by a line terminator. If this all seems reasonable then a CSR will be filed after the code review.

One thing I am uncertain about is the change to skip() at lines 293-295 of LineNumberReader. I am not sure that those  lines should be added.

Thanks,

Brian

[1] https://bugs.openjdk.java.net/browse/JDK-8235792
[2] https://bugs.openjdk.java.net/browse/JDK-8230342
[3] https://bugs.openjdk.java.net/browse/JDK-8235668
[4] http://cr.openjdk.java.net/~bpb/8235792/webrev.00/


More information about the core-libs-dev mailing list