RFR: 8237465: JDK 14 L10N resource files update - msg drop 10

li.jiang at oracle.com li.jiang at oracle.com
Sat Jan 18 02:10:50 UTC 2020


Hi Naoto,

Thank you for reviewing.

The eol characters were removed by t9n system, if I correct the format 
manually the next time we run the msg drop it would be back. Considering 
we need to kick off the next msg drop soon, I prefer not to fix it this 
time.

Regards,
Leo

On 1/18/20 2:31 AM, naoto.sato at oracle.com wrote:
> Hi Leo,
> 
> The l10n files for HelpResources_*.properties in jpackage discard the 
> format in the original English resource file where lines are nicely 
> aligned. Can you please preserve the format?
> 
> Also, I find it odd to observe duplicated String literals in every 
> XPATHErrorResources_*.java files. I think they should only be in the 
> base resource bundles, but I guess that's in the original xml code and 
> not l10n related.
> 
> Naoto
> 
> On 1/17/20 3:31 AM, li.jiang at oracle.com wrote:
>> Hi,
>>
>> Please review the L10N resource files update for JDK 14 msg drop 10.
>>
>> https://bugs.openjdk.java.net/browse/JDK-8237465
>> http://cr.openjdk.java.net/~ljiang/8237465/webrev/read/
>>
>> This is the first msg drop for JDK 14 L10N resources files update, so 
>> this webrev would cover most of update for JDK 14. We still have the 
>> msg drop 20 in the next days, so pls commit the l10n related changes 
>> before Jan 23rd. After msg drop 20, we kick off the msg drop 30 only 
>> if necessary, showstopper only.
>>
>> Note: some resource changes in preview features, like Record, Pattern 
>> Matching, are supported in this msg drop, also some new resource files 
>> for jpackager were added.
>>
>> Thanks,
>> Leo
>>


More information about the core-libs-dev mailing list