RFR: 8237508: Simplify JarFile.isInitializing

Daniel Fuchs daniel.fuchs at oracle.com
Mon Jan 20 11:35:08 UTC 2020


Hi Claes,

Looks OK to me but I'd have a slight preference to a solution
that confines the hack to the JarFile class.

Would making the isIntializing field private and introducing
a static boolean isInitializing() method in JarFile bring the
same benefits WRT startup?

best regards,

-- daniel

On 20/01/2020 11:16, Claes Redestad wrote:
> Hi,
> 
> JDK-8234466[1] introduced isInitializing to JarFile, which cause a small
> startup regression in various tests due increasing the number of classes
> loaded and earlier lambda bootstrapping. The regression can be resolved
> by not explicitly initializing the thread local variable to a non-null
> value.
> 
> Webrev: http://cr.openjdk.java.net/~redestad/8237508/open.00/
> Bug:    https://bugs.openjdk.java.net/browse/JDK-8237508
> 
> Testing: tier1-3
> 
> Thanks!
> 
> /Claes
> 
> [1] https://bugs.openjdk.java.net/browse/JDK-8234466



More information about the core-libs-dev mailing list