[14] 8215361 (doc) Cleanup package-info markup - smartcardio, java.sql, java.sql.rowset

Pavel Rappo pavel.rappo at oracle.com
Thu Jan 23 21:24:26 UTC 2020


Yes, I can see those too. That suggests that the change was not performed automatically. Which makes sense, since sometimes nested tags need to be "turned inside out", e.g. <code><b>...</b></code> -> <b>{@code ...}</b>.

    {@code     java.net.URL url = rowset.getURL(1);}

Will it be rendered as intended? Otherwise looks good.

> On 23 Jan 2020, at 21:05, Lance Andersen <lance.andersen at oracle.com> wrote:
> 
> Hi Roger
> 
> Overall looks OK with the exception of
> java.sql.rowset/share/classes/com/sun/rowset/package-info.java
> ——————
> - * <code><b>CachedRowSetImpl</b></code> - The <code>javax.sql.rowset.CachedRowSet</code> interface
> + * <b>{@code CachedRowSetImpl}</b> - The <code>javax.sql.rowset.CachedRowSet</code> interface
> ————————
> 
> There are a few  entries that seemed to be missed, but all good otherwise 
> 
> HTH
> Lance
> 
>> On Jan 23, 2020, at 3:18 PM, Roger Riggs <Roger.Riggs at oracle.com> wrote:
>> 
>> Please review cleanup of package-info.java files use of <code> -> {@code}.
>> 
>> Webrev:
>>  http://cr.openjdk.java.net/~rriggs/webrev-doc-cleanup-8215361-1/
>> 
>> Issue:
>>  https://bugs.openjdk.java.net/browse/JDK-8215361
>> 
>> Thanks, Roger
>> 
> 
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering 
> 1 Network Drive 
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
> 
> 
> 



More information about the core-libs-dev mailing list